Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/641#discussion_r35109156
--- Diff:
storm-core/src/jvm/backtype/storm/grouping/PartialKeyGrouping.java ---
@@ -65,7 +66,11 @@ public void prepare(WorkerTopologyContext context,
GlobalStreamId stream, List<I
List<Object> selectedFields = outFields.select(fields,
values);
ByteBuffer out = ByteBuffer.allocate(selectedFields.size()
* 4);
for (Object o: selectedFields) {
- out.putInt(o.hashCode());
+ if (o instanceof Object[]) {
--- End diff --
@d2r
Could we add same thing (converting List to Object[] by toArray, and apply
Arrays.deepHashCode()) from list-hash-code to this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
