Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/573#issuecomment-124287695
@sweetest
The code looks great to me overall, too.
Btw, actually I read your post from your company's official technical blog.
(http://d2.naver.com/helloworld/1044388)
This module covers your use case, but IMO some functionalities should be
added to cover more (and general) use cases.
Surely, we can just add to another issues, and implement it later. Here's
the list.
- Introduces Tuple -> ES document mapper to get rid of constant field
mapping (source, index, type)
- Introduces Lookup(or Query)Bolt which retrieves matched documents from ES
and emit them
- Introduces BaseQueryFunction which is same to Lookup(or Query)Bolt but
can be used in Trident topology
For Lookup(or Query)Bolt and BaseQueryFunction, we need to introduce ES
document -> Tuple mapper, and we may want to set which field is used for
querying.
We may also want to consider about the strategy - what we can do when too
many documents are matched.
@revans2 @harshach @sweetest
Please comment me when you're unsure about features I've suggested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
