[
https://issues.apache.org/jira/browse/STORM-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640094#comment-14640094
]
ASF GitHub Bot commented on STORM-951:
--------------------------------------
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/645#discussion_r35401647
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -170,10 +170,10 @@ public void run() {
}
}
- private void flushAllWriters()
+ private void flushAllWriters(boolean rollToNext)
throws HiveWriter.CommitFailure, HiveWriter.TxnBatchFailure,
HiveWriter.TxnFailure, InterruptedException {
for(HiveWriter writer: allWriters.values()) {
- writer.flush(true);
+ writer.flush(rollToNext);
--- End diff --
If ```rollToNext == false``` should we ``` writer.close()``` ?
Like:
```
writer.flush(rollToNext);
if (!rollToNext) {
writer.close();
}
```
> Storm Hive connector leaking connections
> ----------------------------------------
>
> Key: STORM-951
> URL: https://issues.apache.org/jira/browse/STORM-951
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sriharsha Chintalapani
> Assignee: Sriharsha Chintalapani
> Priority: Critical
>
> Incase of failures in execute method we dont' abort transactions. We only
> close connections this can result in lot of uncommitted transactions on hive
> side.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
