Github user DevInsanity commented on the pull request:

    https://github.com/apache/storm/pull/623#issuecomment-124442778
  
    @caofangkun 
    No, we're using a flux based topology and deploying to a remote cluster 
(via `storm.cmd jar project.jar org.apache.storm.flux.Flux --remote 
project.yaml --filter project.properties`).
    
    The problem is that because storm.cmd launches the actual process via 
`start /b` then it doesn't wait for the topology to deploy before returning to 
the caller, so you can't get any error codes back from the deployer (for 
example, if the yaml is invalid).
    
    We're actually invoking this from a maven antrun plugin task as part of 
build process. In that case, it's even worse, as in the case of an error, not 
only does maven still report a build successful (as the antrun plugin's exec 
task doesn't see an error code), but none of the output is captured either. 
With the change, the output from the deployment is captured by maven properly.
    
    While we could specify the storm_debug option explicitly (which would still 
need the quotes added around the %JAVA% to work properly when java is installed 
under Program Files), the jar command doesn't appear to be intended to launch a 
background server, so should wait for it's action to finish before returning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to