[
https://issues.apache.org/jira/browse/STORM-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640177#comment-14640177
]
ASF GitHub Bot commented on STORM-440:
--------------------------------------
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/648#discussion_r35406230
--- Diff: storm-core/src/jvm/backtype/storm/utils/NimbusClient.java ---
@@ -30,11 +30,18 @@
private Nimbus.Client _client;
private static final Logger LOG =
LoggerFactory.getLogger(NimbusClient.class);
+ public static NimbusClient getConfiguredClient() {
+ return getConfiguredClient(null);
+ }
public static NimbusClient getConfiguredClient(Map conf) {
- try {
- String nimbusHost = (String) conf.get(Config.NIMBUS_HOST);
- return new NimbusClient(conf, nimbusHost);
+ try {
+ Map fullConf = Utils.readStormConfig();
+ if (conf != null) {
+ fullConf.putAll(conf);
+ }
+ String nimbusHost = (String) conf.get(Config.NIMBUS_HOST);
+ return new NimbusClient(conf, nimbusHost);
--- End diff --
should be
```
String nimbusHost = (String) fullConf.get(Config.NIMBUS_HOST);
return new NimbusClient(fullConf, nimbusHost);
```
> NimbusClient throws NPE if Config.STORM_THRIFT_TRANSPORT_PLUGIN is not set
> --------------------------------------------------------------------------
>
> Key: STORM-440
> URL: https://issues.apache.org/jira/browse/STORM-440
> Project: Apache Storm
> Issue Type: Bug
> Affects Versions: 0.9.2-incubating
> Reporter: Bryan Baugher
> Assignee: Sanket Reddy
> Priority: Minor
>
> We just upgraded from 0.8.2 to 0.9.2 and noticed that when constructing a
> NimbusClient if Config.STORM_THRIFT_TRANSPORT_PLUGIN is not specified then
> AuthUtils[1] throws a NPE.
> [1] -
> https://github.com/bbaugher/incubator-storm/blob/master/storm-core/src/jvm/backtype/storm/security/auth/AuthUtils.java#L73-L74
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
