[
https://issues.apache.org/jira/browse/STORM-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640224#comment-14640224
]
ASF GitHub Bot commented on STORM-914:
--------------------------------------
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/606#discussion_r35409819
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentSequenceTopology.java
---
@@ -60,7 +61,7 @@ public static StormTopology buildTopology(String hdfsUrl){
.withSequenceFormat(new DefaultSequenceFormat("key",
"sentence"))
.withRotationPolicy(rotationPolicy)
.withFsUrl(hdfsUrl)
- .withConfigKey("hdfs.config")
--- End diff --
@tedxia
if you change ```hdfs.config``` to ```topology.hdfs.config```
should the following several files change too ?
[HdfsFileTopology.java](https://github.com/apache/storm/blob/master/external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/HdfsFileTopology.java#L82)
[simple_hdfs.yaml](https://github.com/apache/storm/blob/master/external/flux/flux-examples/src/main/resources/simple_hdfs.yaml#L74)
[hdfs_test.yaml](https://github.com/apache/storm/blob/master/external/flux/flux-core/src/test/resources/configs/hdfs_test.yaml#L82)
> AutoHDFS should also update hdfs.config into Configuration
> ----------------------------------------------------------
>
> Key: STORM-914
> URL: https://issues.apache.org/jira/browse/STORM-914
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs
> Affects Versions: 0.10.0
> Reporter: xiajun
> Assignee: xiajun
>
> When storm user a specify hdfs cluster, he will put some config such as
> namenode.host into hdfs.config when submit storm topology, and when HdfsBolt
> create HdfsConfiguration, it will use hdfs.config update HDFSConfiguration,
> then HDFSBolt will visit the right hdfs cluster. But in AutoHDFS's renew and
> getHadoopCredentials, Configuration not for the HDFS that storm user specify,
> we should update all the Configuration with hdfs.config.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
