Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/645#discussion_r35425503
  
    --- Diff: 
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
    @@ -170,10 +170,10 @@ public void run() {
             }
         }
     
    -    private void flushAllWriters()
    +    private void flushAllWriters(boolean rollToNext)
             throws HiveWriter.CommitFailure, HiveWriter.TxnBatchFailure, 
HiveWriter.TxnFailure, InterruptedException {
             for(HiveWriter writer: allWriters.values()) {
    -            writer.flush(true);
    +            writer.flush(rollToNext);
    --- End diff --
    
    @caofangkun closing Writer handled in different method you can 
flushAllAndCloseWriters().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to