[jira] [Created] (STORM-966) ConfigValidation.DoubleValidator doesn't really validate whether the type of the object is a double

Wed, 29 Jul 2015 14:09:18 -0700 

Boyang Jerry Peng created STORM-966:
---------------------------------------

             Summary: ConfigValidation.DoubleValidator doesn't really validate 
whether the type of the object is a double
                 Key: STORM-966
                 URL: https://issues.apache.org/jira/browse/STORM-966
             Project: Apache Storm
          Issue Type: Improvement
            Reporter: Boyang Jerry Peng
            Priority: Minor


ConfigValidation.DoubleValidator code only checks if the object is null whether 
if the object is a instance of Number which is a parent class of Double.

DoubleValidator is only used once in Config.java and in that instance:

public static final Object TOPOLOGY_STATS_SAMPLE_RATE_SCHEMA = 
ConfigValidation.DoubleValidator;

can just be set to:

public static final Object TOPOLOGY_STATS_SAMPLE_RATE_SCHEMA = Double.class;

Then we can just get rid of the misleading function 
ConfigValidation.DoubleValidator since it doesn't really check if a object is 
of double type





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to