[ 
https://issues.apache.org/jira/browse/STORM-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647121#comment-14647121
 ] 

ASF GitHub Bot commented on STORM-964:
--------------------------------------

Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/657#discussion_r35835399
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -675,6 +675,7 @@
                             (add-to-classpath topo-classpath))
               top-gc-opts (storm-conf TOPOLOGY-WORKER-GC-CHILDOPTS)
               gc-opts (substitute-childopts (if top-gc-opts top-gc-opts (conf 
WORKER-GC-CHILDOPTS)) worker-id storm-id port)
    +          topo-worker-logwriter-childopts (conf 
TOPOLOGY-WORKER-LOGWRITER-CHILDOPTS)
    --- End diff --
    
    Good catch. Since user may have configuration for this in topology's 
stormconf.ser. Updated.


> Add config (with small default value) for logwriter to restrict its memory 
> usage
> --------------------------------------------------------------------------------
>
>                 Key: STORM-964
>                 URL: https://issues.apache.org/jira/browse/STORM-964
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>
> The log writer process that writes out stderr and stdout should have a config 
> that controls it's memory usage and it should default to a very small value, 
> probably 50-60MB in most cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to