Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/658#issuecomment-126513135
  
    You're right about DoubleValidator. DoubleValidator is not properly 
implemented.
    
    Btw, Number.class seems not the proper thing to rely, too.
    http://docs.oracle.com/javase/7/docs/api/java/lang/Number.html
    
    BigInteger and BigDecimal extends Number, so if we don't want to handle big 
numbers in configuration, we should have properly implemented DoubleValidator 
(It should check the value is not beyond the range of Double), and don't use 
Number.class to validate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to