[ 
https://issues.apache.org/jira/browse/STORM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681175#comment-14681175
 ] 

ASF GitHub Bot commented on STORM-977:
--------------------------------------

Github user caofangkun commented on a diff in the pull request:

    https://github.com/apache/storm/pull/672#discussion_r36708996
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -262,7 +262,7 @@
           (psim/kill-process thread-pid))
         (doseq [pid pids]
           (if as-user
    -        (worker-launcher-and-wait conf user ["signal" pid "9"] :log-prefix 
(str "kill -15 " pid))
    +        (worker-launcher-and-wait conf user ["signal" pid "9"] :log-prefix 
(str "kill -9 " pid))
    --- End diff --
    
    I think should change the signal value but not the ```log-prefix```
    should be 
     ```(worker-launcher-and-wait conf user ["signal" pid "15"] :log-prefix 
(str "kill -15 " pid))```


> Incorrect log prefix (-15) when sending -9 signal to worker
> -----------------------------------------------------------
>
>                 Key: STORM-977
>                 URL: https://issues.apache.org/jira/browse/STORM-977
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Derek Dagit
>            Priority: Trivial
>              Labels: Newbie
>
> https://github.com/apache/storm/blob/544e55cb8ab8878c4af500aab49bd35d4b69cd3e/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L265



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to