Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/609#issuecomment-129860736
@HeartSaVioR
This PR works with hive.version=1.0.0 By "works" I mean that it compiles
and passes all unit tests.
It does NOT work with hive.version=1.2.1 (the version of Hive that ships
with HDP 2.3). Hive 1.2.1 depends on Calcite 1.2.0 and several tests fail if
it's excluded. I could get past these first problems by updating the calcite
version in storm-hive/pom.xml to 1.2.0. However, one test still fails (see
below). I have not had time to investigate these further, but it looks like
some Hive behavior changes unrelated to the calcite dependency issue.
A new JIRA for Hive 1.2.1 support seems appropriate for that issue.
```
Running org.apache.storm.hive.bolt.TestHiveBolt
Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.488 sec
<<< FAILURE! - in org.apache.storm.hive.bolt.TestHiveBolt
testWithTimeformat(org.apache.storm.hive.bolt.TestHiveBolt) Time elapsed:
0.692 sec <<< FAILURE!
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
collector.ack(
source: null:1, stream: , id: {}, [100, test-123, null, null]
);
-> at
org.apache.storm.hive.bolt.TestHiveBolt.testWithTimeformat(TestHiveBolt.java:235)
However, there were other interactions with this mock:
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
at
org.apache.storm.hive.bolt.TestHiveBolt.testWithTimeformat(TestHiveBolt.java:235)
Running org.apache.storm.hive.common.TestHiveWriter
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.387 sec -
in org.apache.storm.hive.common.TestHiveWriter
Results :
Failed tests:
TestHiveBolt.testWithTimeformat:235
Wanted but not invoked:
collector.ack(
source: null:1, stream: , id: {}, [100, test-123, null, null]
);
-> at
org.apache.storm.hive.bolt.TestHiveBolt.testWithTimeformat(TestHiveBolt.java:235)
However, there were other interactions with this mock:
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
Tests run: 12, Failures: 1, Errors: 0, Skipped: 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
