[
https://issues.apache.org/jira/browse/STORM-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14681754#comment-14681754
]
ASF GitHub Bot commented on STORM-944:
--------------------------------------
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/609#issuecomment-129860736
@HeartSaVioR
This PR works with hive.version=1.0.0 By "works" I mean that it compiles
and passes all unit tests.
It does NOT work with hive.version=1.2.1 (the version of Hive that ships
with HDP 2.3). Hive 1.2.1 depends on Calcite 1.2.0 and several tests fail if
it's excluded. I could get past these first problems by updating the calcite
version in storm-hive/pom.xml to 1.2.0. However, one test still fails (see
below). I have not had time to investigate these further, but it looks like
some Hive behavior changes unrelated to the calcite dependency issue.
A new JIRA for Hive 1.2.1 support seems appropriate for that issue.
```
Running org.apache.storm.hive.bolt.TestHiveBolt
Tests run: 9, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.488 sec
<<< FAILURE! - in org.apache.storm.hive.bolt.TestHiveBolt
testWithTimeformat(org.apache.storm.hive.bolt.TestHiveBolt) Time elapsed:
0.692 sec <<< FAILURE!
org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
collector.ack(
source: null:1, stream: , id: {}, [100, test-123, null, null]
);
-> at
org.apache.storm.hive.bolt.TestHiveBolt.testWithTimeformat(TestHiveBolt.java:235)
However, there were other interactions with this mock:
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
at
org.apache.storm.hive.bolt.TestHiveBolt.testWithTimeformat(TestHiveBolt.java:235)
Running org.apache.storm.hive.common.TestHiveWriter
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.387 sec -
in org.apache.storm.hive.common.TestHiveWriter
Results :
Failed tests:
TestHiveBolt.testWithTimeformat:235
Wanted but not invoked:
collector.ack(
source: null:1, stream: , id: {}, [100, test-123, null, null]
);
-> at
org.apache.storm.hive.bolt.TestHiveBolt.testWithTimeformat(TestHiveBolt.java:235)
However, there were other interactions with this mock:
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
-> at
backtype.storm.task.OutputCollector.reportError(OutputCollector.java:223)
-> at backtype.storm.task.OutputCollector.fail(OutputCollector.java:218)
Tests run: 12, Failures: 1, Errors: 0, Skipped: 0
```
> storm-hive pom.xml has a dependency conflict with calcite
> ---------------------------------------------------------
>
> Key: STORM-944
> URL: https://issues.apache.org/jira/browse/STORM-944
> Project: Apache Storm
> Issue Type: Bug
> Components: external
> Reporter: Aaron Dossett
> Assignee: Aaron Dossett
> Priority: Trivial
>
> Hive 0.14.0 has a dependency on calcite-0.9.2-incubating-SNAPSHOT which can't
> be resolved in maven central. See HIVE-8906 for details.
> This gives a harmless compile warning for storm-hive but it does prevent some
> IDEs (IntelliJ for certain, probably others) from correctly resolving the
> project dependencies. storm-hive already has a dependency on
> calcite-0.9.2-incubating so calcite should be excluded from the hive
> dependency.
> Compile warning:
> [WARNING] Missing POM for
> org.apache.calcite:calcite-core:jar:0.9.2-incubating-SNAPSHOT
> [WARNING] Missing POM for
> org.apache.calcite:calcite-avatica:jar:0.9.2-incubating-SNAPSHOT
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
