[jira] [Commented] (STORM-974) [storm-elasticsearch] Introduces Tuple -> ES document mapper to get rid of constant field mapping (source, index, type)

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694633#comment-14694633
 ] 

ASF GitHub Bot commented on STORM-974:
--------------------------------------

Github user caofangkun commented on a diff in the pull request:

    https://github.com/apache/storm/pull/679#discussion_r36938233
  
    --- Diff: 
external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/bolt/EsIndexBoltTest.java
 ---
    @@ -20,6 +20,7 @@
     import backtype.storm.tuple.Tuple;
     import org.apache.storm.elasticsearch.common.EsConfig;
     import org.apache.storm.elasticsearch.common.EsTestUtil;
    +import org.apache.storm.elasticsearch.common.EsTupleMapper;
     import org.elasticsearch.action.count.CountRequest;
     import org.elasticsearch.action.count.CountRequestBuilder;
     import org.elasticsearch.action.count.CountResponse;
    --- End diff --
    
    Line 24 25 27 are unnecessary imports too 


> [storm-elasticsearch] Introduces Tuple -> ES document mapper to get rid of 
> constant field mapping (source, index, type)
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-974
>                 URL: https://issues.apache.org/jira/browse/STORM-974
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> For now EsIndexBolt uses constant field mapping (source, index, type) which 
> is not flexible.
> We can introduce tuple -> ES document mapper interface to let users define 
> their relationship, as other external modules did.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)