Github user wangli1426 commented on a diff in the pull request:
https://github.com/apache/storm/pull/680#discussion_r36938783
--- Diff: storm-core/src/clj/backtype/storm/timer.clj ---
@@ -53,8 +53,11 @@
;; event generation. If any recurring
events
;; are scheduled then we will always go
;; through this branch, sleeping only
the
- ;; exact necessary amount of time.
- (Time/sleep (- time-millis
(current-time-millis)))
+ ;; exact necessary amount of time. We
give
+ ;; an upper bound, e.g. 1000 millis, to
the
+ ;; sleeping time, to limit the response
time
+ ;; for detecting any new event within 1
secs.
+ (Time/sleep (max 1000 (- time-millis
(current-time-millis))))
--- End diff --
Yes, you are right, min should be used definitely. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
