[
https://issues.apache.org/jira/browse/STORM-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697597#comment-14697597
]
ASF GitHub Bot commented on STORM-965:
--------------------------------------
GitHub user priyank5485 opened a pull request:
https://github.com/apache/storm/pull/686
STORM-965: Fix excessive logging
The reason for this pull request is that when a non-secure client tries to
connect to nimbus host in a secure cluster, an exception was being thrown and a
null transport object was being returned. This null object in turn was being
used by thrift library class and threw a null pointer exception. Both the
classes where exception was thrown and caught were logging this exception,
creating unnecessary lengthy log statements. Disabling logging in storm code by
changing it from error to debug took care of one part but to work around the
issue of exception being logged in the thrift jar a NoOpTTrasport.java had to
be created. Two main things to consider during review
1. Change from Logger.error to Logger.debug in
KerberosSaslTransportPlugin.java
2. Early return false in SaslTransportPlugin.java which is presumed and
tested with one nimbus client to work okay.
Note: TProcess interface process method does not have documentation saying
what the returned boolean indicates.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/priyank5485/storm STORM-965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/686.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #686
----
commit f29de472a21a9f5936cb13d26cc5a36669c48164
Author: Priyank <[email protected]>
Date: 2015-08-13T22:42:24Z
STORM-965: Fix excessive logging
----
> excessive logging in storm when non-kerberos client tries to connect.
> ---------------------------------------------------------------------
>
> Key: STORM-965
> URL: https://issues.apache.org/jira/browse/STORM-965
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sriharsha Chintalapani
> Assignee: Priyank Shah
>
> Ambari alert service pings nimbus thrift port to check if the process is
> alive or not. This causes unnecessary logging
> b.s.s.a.k.KerberosSaslTransportPlugin [ERROR] Storm server failed to open
> transport to interact with a client during session initiation:
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at org.apache.thrift7.transport.TSocket.open(TSocket.java:170)
> ~[storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> org.apache.thrift7.transport.TSaslTransport.open(TSaslTransport.java:266)
> ~[storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> org.apache.thrift7.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> ~[storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> org.apache.thrift7.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> ~[storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> backtype.storm.security.auth.kerberos.KerberosSaslTransportPlugin$TUGIAssumingTransportFactory$1.run(KerberosSaslTransportPlugin.java:195)
> [storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> backtype.storm.security.auth.kerberos.KerberosSaslTransportPlugin$TUGIAssumingTransportFactory$1.run(KerberosSaslTransportPlugin.java:192)
> [storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at java.security.AccessController.doPrivileged(Native Method)
> [na:1.7.0_67]
> at javax.security.auth.Subject.doAs(Subject.java:415) [na:1.7.0_67]
> at
> backtype.storm.security.auth.kerberos.KerberosSaslTransportPlugin$TUGIAssumingTransportFactory.getTransport(KerberosSaslTransportPlugin.java:191)
> [storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> org.apache.thrift7.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:269)
> [storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> [na:1.7.0_67]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> [na:1.7.0_67]
> at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
> 2015-07-17T10:35:52.723+0000 o.a.t.s.TThreadPoolServer [ERROR] Error occurred
> during processing of message.
> java.lang.NullPointerException: null
> at
> backtype.storm.security.auth.SaslTransportPlugin$TUGIWrapProcessor.process(SaslTransportPlugin.java:120)
> ~[storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> org.apache.thrift7.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:285)
> ~[storm-core-0.10.0.2.3.0.0-2557.jar:0.10.0.2.3.0.0-2557]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> [na:1.7.0_67]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> [na:1.7.0_67]
> at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
