Github user rohanag12 commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37159376
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -137,8 +137,14 @@ public EmitState next(SpoutOutputCollector collector) {
}
Iterable<List<Object>> tups =
KafkaUtils.generateTuples(_spoutConfig, toEmit.msg);
if (tups != null) {
- for (List<Object> tup : tups) {
- collector.emit(tup, new KafkaMessageId(_partition,
toEmit.offset));
+ if(_spoutConfig.topicAsStreamId) {
+ for (List<Object> tup : tups) {
--- End diff --
@harshach
Having the if condition check inside the for loop is a performance overhead.
About renaming the variables, I did not name them. The original storm-kafka
creators did. So I am not going to rename them now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
