Github user dossett commented on a diff in the pull request:
https://github.com/apache/storm/pull/664#discussion_r37241329
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java ---
@@ -80,6 +86,11 @@ public HdfsBolt addRotationAction(RotationAction action){
return this;
}
+ public HdfsBolt withTickTupleIntervalSeconds(int interval) {
--- End diff --
I like that change since it separates the function from the implementation.
A similar change could be made to HiveBolt, to which I also added a tick tuple
functionality recently. If this PR is otherwise ok, I'd like to open a new
JIRA to change this bolt and HiveBolt at the same time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
