[
https://issues.apache.org/jira/browse/STORM-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705202#comment-14705202
]
ASF GitHub Bot commented on STORM-829:
--------------------------------------
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/690#issuecomment-133064686
Just a couple comments:
- Would you please include the summary of the Jira in the title of the
pull request
- There are a bunch of commits here. Would you squash them?
- I think the jira calls for the removal of `hadoop-auth` from
storm-core's pom. Have you found a reason for keeping it?
> Hadoop dependency confusion
> ---------------------------
>
> Key: STORM-829
> URL: https://issues.apache.org/jira/browse/STORM-829
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Robert Joseph Evans
>
> The hadoop dependencies seem a bit messed up. We have a hadoop.version set
> in the main pom.xml to 2.6.0 but it does not really appear to be used.
> storm-core uses hadoop-auth set to 2.4.0, storm-hdfs hard codes it to 2.2.0,
> storm-hbase does the same. We should have all of the versions be consistent
> and come from the main pom.xml. Also what are we using hadoop-auth for in
> storm-core.
> Also it looks like we should remove the hadoop-auth dependency. When
> AutoHDFS and AutoHBase moved out of storm-core it looks like it was left
> there by mistake.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)