[
https://issues.apache.org/jira/browse/STORM-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710043#comment-14710043
]
ASF GitHub Bot commented on STORM-954:
--------------------------------------
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/673#discussion_r37803716
--- Diff: storm-core/src/clj/backtype/storm/daemon/common.clj ---
@@ -273,6 +293,26 @@
(metrics-consumer-register-ids storm-conf)
(get storm-conf TOPOLOGY-METRICS-CONSUMER-REGISTER))))
+;; return the fields that event logger bolt expects
+(defn eventlogger-bolt-fields []
+ [(EventLoggerBolt/FIELD_COMPONENT_ID) (EventLoggerBolt/FIELD_TS)
(EventLoggerBolt/FIELD_VALUES)]
+ )
+
+(defn add-eventlogger! [storm-conf ^StormTopology ret]
+ (let [num-executors (if (nil? (storm-conf
TOPOLOGY-EVENTLOGGER-EXECUTORS)) (storm-conf TOPOLOGY-WORKERS) (storm-conf
TOPOLOGY-EVENTLOGGER-EXECUTORS))
--- End diff --
may be i am missing this, but if TOPOLOGY-EVENTLOGGER-EXECUTORS is set to
0, shouldn't you just return? I do not see the logic that just does not add
event logger bolt when TOPOLOGY-EVENTLOGGER-EXECUTORS = 0. Or are we assumin
ghtat as num-executors will be set to 0, no thread will execute this task?
> Toplogy Event Inspector
> -----------------------
>
> Key: STORM-954
> URL: https://issues.apache.org/jira/browse/STORM-954
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Sriharsha Chintalapani
> Assignee: Arun Mahadevan
>
> •Ability to view tuples flowing through the topology
> •Ability to turn on/off debug events without having to stop/restart topology
> •Default debug events is off
> •User should be able to select a specific Spout or Bolt and see incoming
> events and outgoing events
> •We could put a configurable numbers of events to view (e.g. last 100 events
> or last 1 minute)
> •Tuple stream to have following info
> •Message id, batch/transaction id, name/value pair, timestamp, acked (boolean)
> •All the above to be available from Storm UI
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
