Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/697#discussion_r37985888
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
    @@ -359,23 +359,34 @@ public static Object 
getSetComponentObject(ComponentObject obj) {
     
         public static void downloadFromMaster(Map conf, String file, String 
localFile) throws AuthorizationException, IOException, TException {
             NimbusClient client = NimbusClient.getConfiguredClient(conf);
    -        download(client, file, localFile);
    +        try {
    +           download(client, file, localFile);
    +        } finally {
    +           client.close();
    +        }
         }
     
         public static void downloadFromHost(Map conf, String file, String 
localFile, String host, int port) throws IOException, TException, 
AuthorizationException {
             NimbusClient client = new NimbusClient (conf, host, port, null);
    -        download(client, file, localFile);
    +        try {
    +           download(client, file, localFile);
    --- End diff --
    
    Indentation seems mixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to