[
https://issues.apache.org/jira/browse/STORM-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715400#comment-14715400
]
ASF GitHub Bot commented on STORM-1010:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/699#issuecomment-135152145
The changes look fine to me. +1
@harshach we did a similar thing for the HDFS Bolt.
https://github.com/apache/storm/blob/ffb1562cb0eb3fbd916423136fcd3c181fbf6212/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java#L53-L56
Each bolt needs to be able to be configured independently of all other
bolts. Putting it in the conf is a is one way to do it, but I have seen a lot
of bolts do it through a setter too. I personally would prefer to support both
through a config and through an API. The only trick is with consistency and
ordering in the case of conflicts.
> Each KafkaBolt could have a specified properties.
> -------------------------------------------------
>
> Key: STORM-1010
> URL: https://issues.apache.org/jira/browse/STORM-1010
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Renkai Ge
> Assignee: Renkai Ge
> Priority: Minor
>
> Now KafkaBolt producer properties could only be set by
> conf.put(KafkaBolt.KAFKA_BROKER_PROPERTIES, props);
> which means all bolts in a topology use the same version of properties.
> A KafkaBolt may need it's own properties sometimes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
