[ 
https://issues.apache.org/jira/browse/STORM-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730679#comment-14730679
 ] 

ASF GitHub Bot commented on STORM-1027:
---------------------------------------

GitHub user abhishekagarwal87 opened a pull request:

    https://github.com/apache/storm/pull/719

    STORM-1027: Use overflow buffer for emitting metrics

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/abhishekagarwal87/storm work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #719
    
----
commit 3144a533b7ae069cd23483544cc58fa962d88fda
Author: Abhishek Agarwal <[email protected]>
Date:   2015-09-04T11:45:02Z

    STORM-1027: Use overflow buffer for emitting metrics

----


> Topology may hang because metric-tick function is a blocking call from spout
> ----------------------------------------------------------------------------
>
>                 Key: STORM-1027
>                 URL: https://issues.apache.org/jira/browse/STORM-1027
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Abhishek Agarwal
>
> Nathan had fixed the dining philosopher problem by putting a overflow buffer 
> in the spout so that spout is not blocking. However, overflow buffer is not 
> used when emitting the metric, and that could result in the deadlock. I 
> modified the executor to use overflow buffer for emitting metrics and 
> afterwards topology didn't hang. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to