[
https://issues.apache.org/jira/browse/STORM-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14734197#comment-14734197
]
ASF GitHub Bot commented on STORM-912:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/717#discussion_r38888659
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -951,17 +958,17 @@
(GET "/api/v1/topology/summary" [:as {:keys [cookies servlet-request]} &
m]
(assert-authorized-user servlet-request "getClusterInfo")
(json-response (all-topologies-summary) (:callback m)))
- (GET "/api/v1/topology/:id" [:as {:keys [cookies servlet-request]} id &
m]
+ (GET "/api/v1/topology/:id" [:as {:keys [cookies servlet-request
schema]} id & m]
--- End diff --
@knusbaum
I don't know about compojure / ring, and I can't find related docs, but
core.clj from master branch uses different key name.
Actually master branch uses both schema and scheme.
- route which uses schema as key:
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L997
- route which uses scheme as key:
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L1004
Which one is correct? Or both things are correct?
> Support SSL on Logviewer
> ------------------------
>
> Key: STORM-912
> URL: https://issues.apache.org/jira/browse/STORM-912
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Kyle Nusbaum
> Assignee: Kyle Nusbaum
> Priority: Minor
> Fix For: 0.11.0
>
>
> Support SSL on the logviewer like it is in the UI.
> Also detect what method we're using and make sure logviewer links in the UI
> are pointing to the appropriate Logviewer endpoint.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
