Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/745#discussion_r39913836
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -317,7 +317,7 @@ private int iteratorSize(Iterator<TaskMessage> msgs) {
* If the write operation fails, then we will close the channel and
trigger a reconnect.
*/
private void flushMessages(Channel channel, final MessageBatch batch) {
- if(batch.isEmpty()){
+ if(null == batch || batch.isEmpty()){
--- End diff --
style nits:
* `if(` -> `if (`
* `){` -> `) {`
Those are more consistent with the rest of this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
