[ 
https://issues.apache.org/jira/browse/STORM-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900076#comment-14900076
 ] 

ASF GitHub Bot commented on STORM-1055:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/748#discussion_r39935249
  
    --- Diff: external/storm-jdbc/README.md ---
    @@ -3,14 +3,16 @@ Storm/Trident integration for JDBC. This package includes 
the core bolts and tri
     to either insert storm tuples in a database table or to execute select 
queries against a database and enrich tuples 
     in a storm topology.
     
    +**Note**: Throughout the examples below, we make use of 
com.google.common.collect.Lists and com.google.common.collect.Maps.
    +
     ## Inserting into a database.
     The bolt and trident state included in this package for inserting data 
into a database tables are tied to a single table.
     
     ### ConnectionProvider
    -An interface that should be implemented by different connection pooling 
mechanism `org.apache.storm.jdbc.common.ConnectionProvider`
    +An interface that should be implemented by different connection pooling 
mechanism `org.apache.storm.jdbc.common.ConnectionPrvoider`
     
     ```java
    -public interface ConnectionProvider extends Serializable {
    +public interface ConnectionPrvoider extends Serializable {
    --- End diff --
    
    Again, ConnectionProvider is correct, so it shouldn't be changed.


> storm-jdbc README needs fixes and context
> -----------------------------------------
>
>                 Key: STORM-1055
>                 URL: https://issues.apache.org/jira/browse/STORM-1055
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0, 0.11.0
>            Reporter: Randy Gelhausen
>            Assignee: Randy Gelhausen
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to