GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/752
STORM-981 Wait for shutdown DRPC servers while testing in drpc_auth_test
SaslTransportPlugin.getServer() returns TThreadPoolServer, and when
TThreadPoolServer.stop() is called, it just flip a stop flag.
https://github.com/apache/thrift/blob/0.9.2/lib/java/src/org/apache/thrift/server/TThreadPoolServer.java
Actual shutdown takes some time, so sometimes another unit test runs while
TThreadPoolServer is being shutdown.
Fortunately, it calls setServing(false) when shutdown is completed.
I ran whole tests from Travis CI five times and drpc_auth_test is always
succeed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #752
----
commit 4740a94c5233432c4e6f2f9022cb422cfa7f1b20
Author: Jungtaek Lim <[email protected]>
Date: 2015-09-21T23:03:59Z
Wait for shutdown DRPC servers while testing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
