[
https://issues.apache.org/jira/browse/STORM-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906604#comment-14906604
]
ASF GitHub Bot commented on STORM-1068:
---------------------------------------
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/762#issuecomment-142980713
Looks OK to me. +1 pending travis CI build passes.
> Configure request.required.acks to be 1 in KafkaUtilsTest for sync
> ------------------------------------------------------------------
>
> Key: STORM-1068
> URL: https://issues.apache.org/jira/browse/STORM-1068
> Project: Apache Storm
> Issue Type: Test
> Components: storm-kafka
> Reporter: Zhuo Liu
> Assignee: Zhuo Liu
> Priority: Minor
>
> In KafkaProducer, request.required.acks is by default 0. In KafkaUtilsTest,
> if we don't set it to be 1, the send(xx).get() may not actually synchronize
> as expected, which can potentially cause offset out-of-range error when the
> consumer tries to read something. BTW, in KafkaBoltTest, we already have this
> set appropriately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
