[ 
https://issues.apache.org/jira/browse/STORM-817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933586#comment-14933586
 ] 

ASF GitHub Bot commented on STORM-817:
--------------------------------------

Github user Parth-Brahmbhatt commented on a diff in the pull request:

    https://github.com/apache/storm/pull/561#discussion_r40577765
  
    --- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaUtils.java ---
    @@ -82,11 +82,9 @@ public static long getOffset(SimpleConsumer consumer, 
String topic, int partitio
         public static class KafkaOffsetMetric implements IMetric {
             Map<Partition, Long> _partitionToOffset = new HashMap<Partition, 
Long>();
             Set<Partition> _partitions;
    -        String _topic;
             DynamicPartitionConnections _connections;
     
    -        public KafkaOffsetMetric(String topic, DynamicPartitionConnections 
connections) {
    -            _topic = topic;
    --- End diff --
    
    any reason we have to delete this? I am thinking about the case where some 
users will have graphs setup on per topic bases and it will be broken after 
this change.


> Kafka Wildcard Topic Support
> ----------------------------
>
>                 Key: STORM-817
>                 URL: https://issues.apache.org/jira/browse/STORM-817
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-kafka
>            Reporter: Sumit Chawla
>            Assignee: Sumit Chawla
>
> Creating a feature request for supporting Wildcard Topic's for Kafka Spout.  
> We want to be able to run a aggregation stream for data coming from all 
> tenants. Tenants get added dynamically. So new kafka topics get created. All 
> the topics will be matching a regex pattern. 
> example:
> clickstream:tenant1:log
> clickstream:tenant2:log
> clickstream:tenant3:log
> Storm code should be able to perform auto-discovery, and should be able to to 
> fetch from newly created topics in run time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to