Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/561#discussion_r40577765
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaUtils.java ---
@@ -82,11 +82,9 @@ public static long getOffset(SimpleConsumer consumer,
String topic, int partitio
public static class KafkaOffsetMetric implements IMetric {
Map<Partition, Long> _partitionToOffset = new HashMap<Partition,
Long>();
Set<Partition> _partitions;
- String _topic;
DynamicPartitionConnections _connections;
- public KafkaOffsetMetric(String topic, DynamicPartitionConnections
connections) {
- _topic = topic;
--- End diff --
any reason we have to delete this? I am thinking about the case where some
users will have graphs setup on per topic bases and it will be broken after
this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
