[ 
https://issues.apache.org/jira/browse/STORM-1063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935543#comment-14935543
 ] 

ASF GitHub Bot commented on STORM-1063:
---------------------------------------

Github user jerrypeng commented on the pull request:

    https://github.com/apache/storm/pull/760#issuecomment-144137713
  
    LGTM +1


> Workers cannot find log4j configuration files since default value of 
> storm.log4j2.conf.dir is relative
> ------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-1063
>                 URL: https://issues.apache.org/jira/browse/STORM-1063
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 0.11.0
>            Reporter: Jungtaek Lim
>            Assignee: Zhuo Liu
>
> For current 0.11.0-SNAPSHOT, default value of storm.log4j2.conf.dir is 
> "log4j2".
> The problem is, it's never converted to absolute path.
> Workers try to find cluster.xml or worker.xml from log4j2 directory with 
> relative path.
> In my experience, worker logs were printed to supervisor.log file, and it 
> prints some error logs related to this issue.
> {quote}
> 3568678 [Thread-25] WARN  b.s.util - Worker Process 
> 44b1e4e1-67f4-4d44-be80-72a06c217669:990428 [Thread-2] INFO  STDERR - 
> 2015-09-23 07:53:39,350 ERROR File not found in file system or classpath: 
> log4j2/worker.xml
> {quote}
> Other daemons print logs successfully, but its format is weird.
> (Maybe it picked default configuration.)
> 0.10.0 is not affected since it doesn't define default value of 
> storm.log4j2.conf.dir.
> storm.py concatenates STORM_DIR and log4j2 if storm.log4j2.conf.dir is not 
> defined.
> It came from STORM-976, and relevant PR is 
> https://github.com/apache/storm/pull/684
> (STORM-976 seems not backported to 0.10.x-branch.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to