[ 
https://issues.apache.org/jira/browse/STORM-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935683#comment-14935683
 ] 

ASF GitHub Bot commented on STORM-820:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/554#discussion_r40716500
  
    --- Diff: storm-core/src/clj/backtype/storm/log.clj ---
    @@ -44,3 +46,11 @@
     (defn log-stream
       [& args]
       (apply log/log-stream args))
    +
    +(defmacro log-pprint
    +  [& args]
    +  `(let [^StringWriter writer# (StringWriter.)]
    +     (doall
    +       (for [object# [~@args]]
    +         (pprint object# writer#)))
    +     (log-message "\n" writer#)))
    --- End diff --
    
    Why is there a "\n" before logging the message?


> UI Topology & Component Pages have long load times with large, 
> highly-connected Topologies
> ------------------------------------------------------------------------------------------
>
>                 Key: STORM-820
>                 URL: https://issues.apache.org/jira/browse/STORM-820
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 0.11.0
>            Reporter: Derek Dagit
>            Assignee: Derek Dagit
>
> In the UI, the Topology Page and the Component Page each make a 
> getTopologyInfoWithOpts thrift call to nimbus for executor heartbeat data. 
> Metrics from this data are then aggregated in by the UI daemon for display.
> When large topologies, with high-connectedness, are viewed in this way, the 
> load times for each page can be minutes long.  In addition, heap usage by the 
> nimbus JVM can grow substantially as data for each executor, component, & 
> stream is serialized to be sent to the UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to