[ 
https://issues.apache.org/jira/browse/STORM-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935863#comment-14935863
 ] 

ASF GitHub Bot commented on STORM-893:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/746#discussion_r40730129
  
    --- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
    @@ -1101,6 +1127,33 @@
         public static final Object TOPOLOGY_TASKS_SCHEMA = 
ConfigValidation.IntegerValidator;
     
         /**
    +     * The maximum amount of memory an instance of a spout/bolt will take 
on heap. This enables the scheduler
    +     * to allocate slots on machines with enough available memory.
    +     */
    +    public static final String 
TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB = 
"topology.component.resources.onheap.memory.mb";
    +    public static final Object 
TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB_SCHEMA = 
ConfigValidation.NonNegativeNumberValidator;
    +
    +    /**
    +     * The maximum amount of memory an instance of a spout/bolt will take 
off heap. This enables the scheduler
    +     * to allocate slots on machines with enough available memory.
    +     */
    +    public static final String 
TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB = 
"topology.component.resources.offheap.memory.mb";
    +    public static final Object 
TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB_SCHEMA = 
ConfigValidation.NonNegativeNumberValidator;
    +
    +    /**
    +     * The config indicates the percentage of cpu for a core. Assuming the 
a core value to be 100, a
    --- End diff --
    
    This is a bit confusing I think you mean the percentage of a cpu core a 
component will take.
    
    All of the configs should probably mention that this is the default value 
for components that don't override the value.


> Resource Aware Scheduling
> -------------------------
>
>                 Key: STORM-893
>                 URL: https://issues.apache.org/jira/browse/STORM-893
>             Project: Apache Storm
>          Issue Type: Umbrella
>            Reporter: Robert Joseph Evans
>            Assignee: Boyang Jerry Peng
>         Attachments: resource_aware_scheduler_api.pdf
>
>
> At Yahoo we have been working on resource aware scheduling in storm, based 
> off of some work done in academia.  This rollup ticket is to track the 
> complete project.  With several sub tasks.  Some that are already done and 
> need to be pushed back, and others that we have not started on yet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to