Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/765#discussion_r40730244
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -489,10 +489,10 @@
(let [path (backpressure-path storm-id node port)
existed (exists-node? cluster-state path false)]
(if existed
- (if (not on?)
- (delete-node cluster-state path)) ;; delete the znode
since the worker is not congested
- (if on?
- (set-ephemeral-node cluster-state path nil acls))))) ;;
create the znode since worker is congested
+ (when (not on?)
--- End diff --
Since there is one conditional statement to run, is there any special
reason for replacing "if" with "when"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
