Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/766#discussion_r40736026
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -518,6 +540,13 @@
(catch KeeperException e
(log-warn-error e "Could not teardown errors for " storm-id))))
+ (teardown-topology-log-config!
--- End diff --
I saw that you are calling it from cleanup thread, I am just wondering why
not call cleanup with all the other topology cleanup methods?
From what I understand the nimbus cleanup thread is designed to identify
topologies that have no nimbus local disk state but their zookeeper state is
somehow not cleared up. It seems like a handler for rare failure scenarios
which we are abusing now. Let me know if you have some other reason for not
deleting this with rest of the topology.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
