Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/780#discussion_r41063314
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/FailedMsgRetryManagerConfig.java ---
@@ -0,0 +1,7 @@
+package storm.kafka;
+
+import java.io.Serializable;
+
+public interface FailedMsgRetryManagerConfig extends Serializable {
--- End diff --
Since this a factory pattern, I would rename this
`FailedMsgRetryManagerFactory`, and the impl
`ExponentialBackoffMsgRetryManagerFactory`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
