Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/668#discussion_r41088509
  
    --- Diff: 
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java ---
    @@ -44,6 +49,25 @@
         private transient FSDataOutputStream out;
         private RecordFormat format;
         private long offset = 0;
    +    private static String defaultSourceDir = "/tmp/source";
    +    private static String defaultDestDir = "/tmp/dest";
    +    private static String defaultFileExtension = ".txt";
    +
    +
    +    public HdfsBolt() {
    +      this(defaultSourceDir, defaultDestDir, defaultFileExtension);
    +    }
    +
    +    public HdfsBolt(String defaultSourceDir, String defaultDestDir, String 
fileExtension) {
    --- End diff --
    
    And not use "default" in the variable names.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to