[
https://issues.apache.org/jira/browse/STORM-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943901#comment-14943901
]
ASF GitHub Bot commented on STORM-1015:
---------------------------------------
Github user choang commented on a diff in the pull request:
https://github.com/apache/storm/pull/705#discussion_r41186998
--- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaSpout.java ---
@@ -43,19 +42,19 @@ public MessageAndRealOffset(Message msg, long offset) {
}
}
- static enum EmitState {
+ enum EmitState {
EMITTED_MORE_LEFT,
EMITTED_END,
NO_EMITTED
}
- public static final Logger LOG =
LoggerFactory.getLogger(KafkaSpout.class);
+ private static final Logger LOG =
LoggerFactory.getLogger(KafkaSpout.class);
SpoutConfig _spoutConfig;
SpoutOutputCollector _collector;
PartitionCoordinator _coordinator;
DynamicPartitionConnections _connections;
- ZkState _state;
+ PartitionStateManagerFactory _partitionStateManagerFactory;
--- End diff --
instead of a factory, you can make the developer declare the StateStore:
```
public void createTopology() {
Spout spout = new KafkaSpout(..., new KafkaStateStore(...));
...
}
```
This should keep the KafkaSpout code much simpler and more explicit, and
eliminate the need for a factory.
> Store Kafka offsets with Kafka's consumer offset management api
> ---------------------------------------------------------------
>
> Key: STORM-1015
> URL: https://issues.apache.org/jira/browse/STORM-1015
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Affects Versions: 0.11.0
> Reporter: Hang Sun
> Priority: Minor
> Labels: consumer, kafka, offset
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Current Kafka spout stores the offsets (and some other states) inside ZK with
> its proprietary format. This does not work well with other Kafka offset
> monitoring tools such as Burrow, KafkaOffsetMonitor etc. In addition, the
> performance does not scale well compared with offsets managed by Kafka's
> built-in offset management api. I have added a new option for Kafka to store
> the same data using Kafka's built-in offset management capability. The change
> is completely backward compatible with the current ZK storage option. The
> feature can be turned on by a single configuration option. Hope this will
> help people who wants to explore the option of using Kafka's built-in offset
> management api.
> References:
> https://cwiki.apache.org/confluence/display/KAFKA/Committing+and+fetching+consumer+offsets+in+Kafka
> https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-OffsetCommit/FetchAPI
> -thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
