[
https://issues.apache.org/jira/browse/STORM-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948956#comment-14948956
]
ASF GitHub Bot commented on STORM-1079:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/772#discussion_r41536283
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseBolt.java
---
@@ -53,21 +61,69 @@ public HBaseBolt withConfigKey(String configKey) {
return this;
}
+ public HBaseBolt withBatchSize(int batchSize) {
+ this.batchSize = batchSize;
+ return this;
+ }
+
+ public HBaseBolt withFlushIntervalSecs(int flushIntervalSecs) {
+ this.flushIntervalSecs = flushIntervalSecs;
+ return this;
+ }
+
+ @Override
+ public Map<String, Object> getComponentConfiguration() {
+ Map<String, Object> conf = super.getComponentConfiguration();
+ if (conf == null) {
+ conf = new Config();
+ }
+
+ if (conf.containsKey("topology.message.timeout.secs") &&
tickTupleInterval == 0) {
+ Integer topologyTimeout =
Integer.parseInt(conf.get("topology.message.timeout.secs").toString());
+ flushIntervalSecs = (int)(Math.floor(topologyTimeout / 2));
+ LOG.debug("Setting flush interval to [" + flushIntervalSecs +
"] based on topology.message.timeout.secs");
--- End diff --
minor nit. Can we use the "{}" for logging instead of using +.
> Batch Puts to HBase
> -------------------
>
> Key: STORM-1079
> URL: https://issues.apache.org/jira/browse/STORM-1079
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hbase
> Reporter: Sriharsha Chintalapani
> Assignee: Sriharsha Chintalapani
> Fix For: 0.11.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
