[
https://issues.apache.org/jira/browse/STORM-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949127#comment-14949127
]
ASF GitHub Bot commented on STORM-430:
--------------------------------------
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/250#discussion_r41551714
--- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java ---
@@ -66,8 +67,14 @@
private AtomicLong flushCheckTimer;
private int flushCheckInterval;
private ScheduledExecutorService scheduler;
+
+ private CountDownLatch authenticatedSignal = null;
+
+ public CountDownLatch getAuthenticatedSignal() {
+ return authenticatedSignal;
+ }
- @SuppressWarnings("rawtypes")
+ @SuppressWarnings("rawtypes")
--- End diff --
It seems the existing Java source uses an indentation of four spaces, but
the new source uses eight. It would be better I think to keep it the same as
the existing source.
> (Security) Allow netty SASL to support encryption/decryption
> ------------------------------------------------------------
>
> Key: STORM-430
> URL: https://issues.apache.org/jira/browse/STORM-430
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Raghavendra Nandagopal
> Attachments: Storm-Netty Secure Layer.pdf
>
>
> SASL provides more then just authentication, it can also provide integraty
> guarantees.
> as described here
> http://docs.oracle.com/javase/7/docs/api/javax/security/sasl/Sasl.html#QOP
> and
> http://docs.oracle.com/javase/7/docs/technotes/guides/security/sasl/sasl-refguide.html
> In order to provide those guarantees encryption is used, and the wrap/unwrap
> methods for the SaslClient and Server must be used. It would be great to
> support this for storm as well, allowing users to configure the level of
> security they want.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
