[ 
https://issues.apache.org/jira/browse/STORM-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949943#comment-14949943
 ] 

ASF GitHub Bot commented on STORM-1095:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/786#discussion_r41599977
  
    --- Diff: storm-core/src/jvm/backtype/storm/tuple/Tuple.java ---
    @@ -37,9 +37,15 @@
         /**
          * Returns the global stream id (component + stream) of this tuple.
    --- End diff --
    
    @mjsax 
    Could you append comment to explain 'broken naming convention, use 
getSourceGlobalStreamId() instead'?


> Tuple.getSourceGlobalStreamid() has wrong camel-case naming
> -----------------------------------------------------------
>
>                 Key: STORM-1095
>                 URL: https://issues.apache.org/jira/browse/STORM-1095
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Trivial
>
> The method Tuple.getSourceGlobalStreamid() should be named 
> Tuple.getSourceGlobalStreamId() to follow camel-case naming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to