[ 
https://issues.apache.org/jira/browse/STORM-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950482#comment-14950482
 ] 

ASF GitHub Bot commented on STORM-1099:
---------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/791#issuecomment-146890241
  
    @ppoulosk your new test seems to be failing with an arity issue.  Please 
take a look at it.
    
    ```
    classname: backtype.storm.supervisor-test / testname: 
test-substitute-childopts-happy-path-arraylist
    Uncaught exception, not in assertion.
    expected: nil
      actual: clojure.lang.ArityException: Wrong number of args (5) passed to: 
supervisor/substitute-childopts
     at clojure.lang.AFn.throwArity (AFn.java:429)
        clojure.lang.AFn.invoke (AFn.java:48)
        backtype.storm.supervisor_test/fn (supervisor_test.clj:584)
        clojure.test$test_var$fn__7670.invoke (test.clj:704)
        clojure.test$test_var.invoke (test.clj:704)
        clojure.test$test_vars$fn__7692$fn__7697.invoke (test.clj:722)
        clojure.test$default_fixture.invoke (test.clj:674)
        clojure.test$test_vars$fn__7692.invoke (test.clj:722)
        clojure.test$default_fixture.invoke (test.clj:674)
        clojure.test$test_vars.invoke (test.clj:718)
        clojure.test$test_all_vars.invoke (test.clj:728)
        clojure.test$test_ns.invoke (test.clj:747)
        clojure.core$map$fn__4553.invoke (core.clj:2624)
        clojure.lang.LazySeq.sval (LazySeq.java:40)
        clojure.lang.LazySeq.seq (LazySeq.java:49)
        clojure.lang.Cons.next (Cons.java:39)
        clojure.lang.RT.boundedLength (RT.java:1735)
        clojure.lang.RestFn.applyTo (RestFn.java:130)
        clojure.core$apply.invoke (core.clj:632)
        clojure.test$run_tests.doInvoke (test.clj:762)
        clojure.lang.RestFn.invoke (RestFn.java:408)
    ```


> worker childopts cannot accept arraylist of strings
> ---------------------------------------------------
>
>                 Key: STORM-1099
>                 URL: https://issues.apache.org/jira/browse/STORM-1099
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>            Reporter: Paul Poulosky
>            Assignee: Paul Poulosky
>
> This used to work on 0.9, but is broken in 0.10.
> If a customer attempts to add a array of strings as a config for 
> topology.worker.childopts, like the following.
> {noformat}
>       config.put("topology.worker.childopts", Arrays.asList("-Xmx1g", 
> "-Dmy.boxus.parameter=mybogusvalue"));
> {noformat}
> The topology will not launch because "[-Xmx1g" will be an argument to the jvm 
> when the supervisor launches it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to