[
https://issues.apache.org/jira/browse/STORM-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957749#comment-14957749
]
ASF GitHub Bot commented on STORM-702:
--------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/432#discussion_r42052527
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -306,7 +327,30 @@ public static ComponentCommon
getComponentCommon(StormTopology topology, String
}
throw new IllegalArgumentException("Could not find component with
id " + id);
}
-
+
+ public static List<String> getStrings(final Object o) {
+ if (o == null) {
+ return Collections.emptyList();
--- End diff --
All of the other lists here are mutable, but this isn't.
I'd rather see a new ArrayList, since it's a public method.
> Apache Exhibitor support
> ------------------------
>
> Key: STORM-702
> URL: https://issues.apache.org/jira/browse/STORM-702
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Aaron Dixon
> Priority: Critical
>
> Storm connects to Zookeeper via an explicit list of zookeeper hosts.
> Apache Exhibitor offers zookeeper cluster discovery and management features
> allowing for dynamically resizing zookeeper clusters, restarting and
> replacing zk machines in the cluster, etc.
> Curator supports creating zookeeper client connections using exhibitor hosts.
> Storm should allow (optionally) for connection to its Zookeeper clusters
> through Exhibitor.
> Here is the github pull request that prompted this ticket, and that
> introduces optional exhibitor configuration and exhibitor support in Storm:
> https://github.com/apache/storm/pull/432
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
