[
https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957813#comment-14957813
]
ASF GitHub Bot commented on STORM-532:
--------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r42055642
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -155,7 +155,9 @@
(or (not (contains? approved-ids id))
(not (matches-an-assignment? hb
assigned-executors)))
:disallowed
- (or
+ (or (or (nil? (:process-id hb)) (not
(exists-process? (:process-id hb)))))
--- End diff --
Double `or` unnecessary.
> Supervisor should restart worker immediately, if the worker process does not
> exist any more
> --------------------------------------------------------------------------------------------
>
> Key: STORM-532
> URL: https://issues.apache.org/jira/browse/STORM-532
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 0.10.0
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Minor
>
> For now
> if the worker process does not exist any more
> Supervisor will have to wait a few seconds for worker heartbeart timeout and
> restart worker .
> If supervisor knows the worker processid and check if the process exists in
> the sync-processes thread ,may need less time to restart worker.
> 1: record worker process id in the worker local heartbeart
> 2: in supervisor sync-processes ,get process id from worker local heartbeat
> and check if the process exits
> 3: if not restart it immediately
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
