[ 
https://issues.apache.org/jira/browse/STORM-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957953#comment-14957953
 ] 

ASF GitHub Bot commented on STORM-1112:
---------------------------------------

Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/800#discussion_r42064214
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
    @@ -685,7 +685,7 @@
               0))
           :kill-fn (:report-error-and-die executor-data)
           :factory? true
    -      :thread-name component-id)]))
    +      :thread-name (str component-id "-executor" (:executor-id 
executor-data)))]))
    --- End diff --
    
    Thanks @HeartSaVioR 
    Currently the executor send queue thread has name like this:
     "Thread-25-disruptor-executor[25 25]-send-queue"
    
    I take similar format to above to be consistent, now we will have executor 
thread name as:
    "Thread-26-spout-executor[25 25]"


> Add executor id to the thread name of the executor thread for debug
> -------------------------------------------------------------------
>
>                 Key: STORM-1112
>                 URL: https://issues.apache.org/jira/browse/STORM-1112
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>            Reporter: Zhuo Liu
>            Assignee: Zhuo Liu
>            Priority: Minor
>
> Currently the thread name of an executor is with just component id, e.g., 
> "Thread-20-split"", which is not informative. 
> Instead, adding the executor-id to the execuctor's thread name can help us 
> debug inside the worker (e.g., using jstack).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to