Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/790#discussion_r42380191
  
    --- Diff: conf/defaults.yaml ---
    @@ -140,7 +140,8 @@ supervisor.memory.capacity.mb: 3072.0
     supervisor.cpu.capacity: 400.0
     
     ### worker.* configs are for task workers
    -worker.childopts: "-Xmx768m"
    +worker.heap.memory.mb: 768
    +worker.childopts: "-Xmx%HEAP-MEM%m"
    --- End diff --
    
    The reason for this is backwards compatibility + flexibility.  If an admin 
has set their own worker.childopts for a given supervisor to say 2GB, we want 
that to have higher priority over what we calculate.  Similarly if someone sets 
topology.worker.childopts it needs to have higher priority over the other two. 
But what if the topology wants to test out the resource aware scheduler on just 
their topology?  With this they can set topology.worker.childopts to 
"-Xmx%HEAP-MEM%m" and override the hard coded 2GB that was there before.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to