Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/813#discussion_r42814836
--- Diff: storm-core/src/clj/backtype/storm/cluster.clj ---
@@ -54,6 +54,10 @@
(when (Utils/isZkAuthenticationConfiguredTopology topo-conf)
[(first ZooDefs$Ids/CREATOR_ALL_ACL)
(ACL. ZooDefs$Perms/READ (Id. "digest"
(DigestAuthenticationProvider/generateDigest payload)))])))
+
+(defn is-nimbus?
--- End diff --
How about removing this and let the caller of mk-distributed-cluster-state
decides whether writer and reader should be separated? (I mean additional
argument or multimethod.)
I think it can achieve loose coupling since ClusterState doesn't need to
know current daemon is nimbus or not. It just wants to know whether writer and
reader should be separated or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
