[
https://issues.apache.org/jira/browse/STORM-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14981322#comment-14981322
]
ASF GitHub Bot commented on STORM-1147:
---------------------------------------
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/storm/pull/831
STORM-1147: Added validation checks and tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Parth-Brahmbhatt/incubator-storm STORM-1147
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit c367fdbd88bf7c8a5b20dc37299bc357b33fd437
Author: Parth Brahmbhatt <[email protected]>
Date: 2015-10-29T21:29:17Z
STORM-1147: Added validation checks and tests.
----
> Storm JDBCBolt should add validation to ensure either insertQuery or table
> name is specified and not both.
> ----------------------------------------------------------------------------------------------------------
>
> Key: STORM-1147
> URL: https://issues.apache.org/jira/browse/STORM-1147
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-jdbc
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Priority: Trivial
> Fix For: 0.11.0
>
>
> The JDBCBolt takes either an insert query or table name but does not do any
> validation check to ensure only one of the two option is provided. We should
> add a validation check and throw an exception with proper messaging to avoid
> confusion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
