Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43548584
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -30,18 +31,20 @@
private HashMap<Integer, ArrayList<ArrayList<TaskMessage>>> bundles =
new HashMap();
public void add(HashMap<Integer, ArrayList<TaskMessage>>
taskTupleSetMap) {
- for (Integer task : taskTupleSetMap.keySet()) {
- addListRefToMap(this.bundles, task, taskTupleSetMap.get(task));
+ for (Map.Entry<Integer, ArrayList<TaskMessage>> entry :
taskTupleSetMap.entrySet()) {
+ Integer task = entry.getKey();
+ addListRefToMap(this.bundles, task, entry.getValue());
--- End diff --
Perhaps this could be simplified to addListRefToMap(this.bundles,
entry.getKey(), entry.getValue());
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
