[
https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983260#comment-14983260
]
ASF GitHub Bot commented on STORM-1152:
---------------------------------------
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/836#discussion_r43549300
--- Diff:
storm-core/src/jvm/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java
---
@@ -162,9 +162,9 @@ public void commit(TransactionAttempt attempt) {
Long txid = attempt.getTransactionId();
Map<String, Object> metas = _cachedMetas.remove(txid);
- for(String partitionId: metas.keySet()) {
- Object meta = metas.get(partitionId);
-
_partitionStates.get(partitionId).rotatingState.overrideState(txid, meta);
+ for(Entry<String, Object> entry: metas.entrySet()) {
+ Object meta = entry.getValue();
--- End diff --
Unless the variable is created to make the code easier to read, this could
be simplified to
_partitionStates.get(entry.getKey()).rotatingState.overrideState(txid,
entry.getValue());
> Change map keySet iteration to entrySet iteration for efficiency
> ----------------------------------------------------------------
>
> Key: STORM-1152
> URL: https://issues.apache.org/jira/browse/STORM-1152
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Minor
>
> Many places keySet iteration is used where entrySet iteration would avoid
> unnecessary key lookup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
